The phrase was coined by James Truslow Adams in The Epic of America, published in 1931.
Nineteen thirty-one. Unemployment near a quarter of the workforce, banks failing, the Dust Bowl beginning. That is when the country produced the phrase for its own optimism, and the phrase stuck.